Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make things safer #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make things safer #222

wants to merge 1 commit into from

Conversation

danielgindi
Copy link

Fallback for requested camera, not crashing when taking pictures at the wrong time

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@danielgindi
Make things safer
cef27f5 
1. Fallback for requested camera
2. Not crashing when taking pictures at the wrong time
3. Callback for state changes - to be able to take actions only when actually ready
4. Query for modes, like is flash available?
@headsvk
Copy link

headsvk commented Feb 7, 2018

This should definitely be merged in, prevents many NPEs.

@abiemann
Copy link

abiemann commented Jun 6, 2018

WHEN WILL THIS BE MERGED?

@abiemann abiemann mentioned this pull request Jun 6, 2018
Open
@danielgindi
Copy link
Author

At least the CLA looks good...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielgindi @googlebot @headsvk @abiemann